Skip to content

add two vars to the alert template variable list #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rogin
Copy link

@rogin rogin commented Apr 19, 2025

Adds "serverName" and "environmentName" to the alert template variable list.
Requires Java 9+.

Fixes NextGen request #6261.

Previous PR is #6262.

Slight tangent: I deleted KeyEncryptorTest to get over / ignore its java 9+ error that I don't care to investigate as I believe it's unrelated to this code change: error: package com.sun.crypto.provider is not visible.

Assuming we have documentation, it should be updated as two additional variables will display in the Alert Template variable list.

Test procedure:

  1. Compile this patch with Java 9+ and start server
  2. Login and get past initial account setup
  3. Set Server Name and Environment Name under Settings tab
  4. Import and deploy the two attached channels
  5. Import the attached alert (remove its .txt extension after downloading)
  6. Open the imported alert and validate two additional options are present on the right-hand side: "serverName" and "environmentName"
  7. Validate the two additional options can be copied into the template text area
  8. Send any message to channel "throws error"
  9. Validate the resulting text in channel "Receiver" contains the Server Name and Environment Name as you defined in the Settings tab
  10. Clear the Server Name and Environment Name under Settings tab, then re-run a message to ensure the alert template's values are replaced with empty strings

throws.error.xml.txt
Receiver.xml.txt
Foo.alert.xml.txt

jonbartels
jonbartels previously approved these changes Apr 20, 2025
fixed wrong website https://openintegration.org -> https://openintegrationengine.org

Signed-off-by: Gabriele <[email protected]>
Signed-off-by: Richard Ogin <[email protected]>
@rogin rogin force-pushed the alerts-add-envname branch 2 times, most recently from 0f91658 to fd5d84f Compare April 21, 2025 02:22
@rogin
Copy link
Author

rogin commented Apr 21, 2025

You can tell how often I use git for these situations. Need help getting just my commit signed and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants